NVIDIA / TransformerEngine

A library for accelerating Transformer models on NVIDIA GPUs, including using 8-bit floating point (FP8) precision on Hopper and Ada GPUs, to provide better performance with lower memory utilization in both training and inference.

https://docs.nvidia.com/deeplearning/transformer-engine/user-guide/index.html

Apache License 2.0

1.61k stars 256 forks source link

[PyTorch] Fixed assert on primary Fp8 weights in `prepare_te_modules_for_fsdp()` #916

Closed denera closed 3 weeks ago

denera commented 3 weeks ago

Description

This PR fixes misplaced asserts on a module attribute that only exists for TE modules, but is incorrectly applied to non-TE modules.

Supersedes #913.

Type of change

[ ] Documentation change (change only to the documentation, either a fix or a new content)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Changes

Assert on Fp8 primary weights are now applied only for TE modules with primary_weights_in_fp8 attribute.

Checklist:

[x] I have read and followed the contributing guidelines
[x] The functionality is complete
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

ksivaman commented 3 weeks ago

LGTM