NVIDIA / TransformerEngine

A library for accelerating Transformer models on NVIDIA GPUs, including using 8-bit floating point (FP8) precision on Hopper and Ada GPUs, to provide better performance with lower memory utilization in both training and inference.

https://docs.nvidia.com/deeplearning/transformer-engine/user-guide/index.html

Apache License 2.0

1.6k stars 255 forks source link

[JAX] Fixing `unused-variable` warning at TE/JAX extension compile #937

Closed denera closed 2 weeks ago

denera commented 2 weeks ago

Description

Plain C asserts in TE/JAX custom ops get optimized out of the code at compile time and trigger unused-variable warnings. This PR replaces these asserts with NVTE_CHECK() to avoid the warnings. Also removes unused SM margin variables.

Type of change

[ ] Documentation change (change only to the documentation, either a fix or a new content)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Infra/Build change
[x] Code refractor

Changes

Replace C asserts in TE/JAX with NVTE_CHECK.
Remove unused sm_margin.

Checklist:

[x] I have read and followed the contributing guidelines
[x] The functionality is complete
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

phu0ngng commented 2 weeks ago

LGTM!