NVIDIA / TransformerEngine

A library for accelerating Transformer models on NVIDIA GPUs, including using 8-bit floating point (FP8) precision on Hopper and Ada GPUs, to provide better performance with lower memory utilization in both training and inference.

https://docs.nvidia.com/deeplearning/transformer-engine/user-guide/index.html

Apache License 2.0

1.6k stars 255 forks source link

[PyTorch] Fix tp_group_initialized error #939

Closed cyanguwa closed 2 weeks ago

cyanguwa commented 2 weeks ago

Description

Add appropriate logic for tp_group_initialized after making DotProductAttention a TransformerEngineBaseModule.

Type of change

[ ] Documentation change (change only to the documentation, either a fix or a new content)
[ x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Infra/Build change
[ ] Code refractor

Changes

Please list the changes introduced in this PR:

Add proper logic for tp_group_initialized in DotProductAttention.__init__()

Checklist:

[ x] I have read and followed the contributing guidelines
[ x] The functionality is complete
[ x] I have commented my code, particularly in hard-to-understand areas
[ x] I have made corresponding changes to the documentation
[ x] My changes generate no new warnings
[ x] I have added tests that prove my fix is effective or that my feature works
[ x] New and existing unit tests pass locally with my changes

cyanguwa commented 2 weeks ago

/te-ci pytorch