NVIDIA / VariantWorks

Deep Learning based variant calling toolkit - https://clara-parabricks.github.io/VariantWorks/
Apache License 2.0
44 stars 11 forks source link

MultiZMW stitching, model structure inputs, log(0) fixes #142

Closed michaelbrownid closed 3 years ago

michaelbrownid commented 4 years ago

Hi,

The code now allows multiple ZMWs in a HDF5 file to run inference and stitching. I will switch my branch from master to dev-v0.1.0 after this to sync with you.

GPUtester commented 4 years ago

Can one of the admins verify this patch?

tijyojwad commented 3 years ago

add to allowlist

tijyojwad commented 3 years ago

@michaelbrownid this is an awesome change. would it be okay if we leave a couple of comments on this itself for suggested changes, or would you prefer we fork from this branch and make the changes we're thinking of and push separately?

michaelbrownid commented 3 years ago

Logistically, I'm good whatever is easiest to allow us both to be in sync.

tijyojwad commented 3 years ago

@michaelbrownid I pushed some updates to your branch itself - logic is the same, just updated some variable names and refactored a bit.

tijyojwad commented 3 years ago

add to allowlist

tijyojwad commented 3 years ago

rerun tests

tijyojwad commented 3 years ago

ok to test

tijyojwad commented 3 years ago

rerun tests

mike-wendt commented 3 years ago

rerun tests

tijyojwad commented 3 years ago

rerun tests

raydouglass commented 3 years ago

rerun tests

raydouglass commented 3 years ago

add to allowlist