search

NVIDIA / VideoProcessingFramework

Set of Python bindings to C++ libraries which provides full HW acceleration for video decoding, encoding and GPU-accelerated color space and pixel format conversions
Apache License 2.0
1.32k stars 233 forks source link

Add cmake to pip build requirements #447

Closed theHamsta closed 1 year ago

theHamsta commented 1 year ago

@gedoensmax do you think we should install CMake by default? Could avoid installation issues for some users. Even "torch" now

Should we also set the XXX for libnvidia-{encode,decode}-XXX with some reasonable default. It will be the latest versions available anyway.

gedoensmax commented 1 year ago

Is this true ? That wehen i install libnvidia-encode-520 it will go ahead and install the newest ?

theHamsta commented 1 year ago

Is this true ? That when i install libnvidia-encode-520 it will go ahead and install the newest ?

It will install newest but will uninstall the libnvidia-encode-XXX package of whatever is is your driver. Maybe we should ask for a libnvidia-encode/`libnvidia-decode meta-package

gedoensmax commented 1 year ago

I also got some confused questions about the libnvidia-encode package. Maybe we should just give the guidance to have a driver >520 installed.

theHamsta commented 1 year ago

I also got some confused questions about the libnvidia-encode package. Maybe we should just give the guidance to have a driver >520 installed.

I didn't do any changes for this PR. We can have it a separate change