search

NVIDIA / aistore

AIStore: scalable storage for AI applications
https://aistore.nvidia.com
MIT License
1.21k stars 160 forks source link

Update common_requirements #165

Closed satyatumati closed 6 months ago

satyatumati commented 6 months ago

Includes bug fixes

Signed-off-by: Satya Tumati satyavasanth@g.ucla.edu

gaikwadabhishek commented 6 months ago

Hey @satyatumati , Thank you for your first contribution. Why do we need this bump in pydantic?

gaikwadabhishek commented 6 months ago

Your commit isn't signed. Please review https://github.com/NVIDIA/aistore/blob/main/CONTRIBUTING.md

satyatumati commented 6 months ago

Unless this is upgraded, customers like us who use newer version of pydantic which includes bug fixes are blocked by Dependency conflicts

gaikwadabhishek commented 6 months ago

Sounds good. Can you rebase and squash all 4 commits into 1. I will approve, merge and trigger a pipeline to deploy newer version of aistore python SDK

satyatumati commented 6 months ago

Created a new pr. This got messed up. https://github.com/NVIDIA/aistore/pull/166 Thanks