search

NVIDIA / apex

A PyTorch Extension: Tools for easy mixed precision and distributed training in Pytorch
BSD 3-Clause "New" or "Revised" License
8.34k stars 1.39k forks source link

Add custom build backend to support build args #1692

Open janEbert opened 1 year ago

janEbert commented 1 year ago

This implements a custom build backend, inspired by the solution used by Pillow.

--build-options aren't actually passed to the build_wheel command for reasons unknown to me. So this patches setuptools.build_meta to take the flags manually.

The setuptools version requirement of 40.8.0 was also adopted from Pillow. It is the version that introduced the build_meta:__legacy__ backend.

This actually fixes what #1690 meant to do and seems fully backward-compatible.

janEbert commented 1 year ago

Ref #1679.

Quentin-Anthony commented 11 months ago

I and others are still facing issues that this PR, coupled with https://github.com/NVIDIA/apex/pull/1680, would resolve. Is there anything I can do (testing, fix any remaining hangups, etc) to get this merged into upstream?

loadams commented 11 months ago

@crcrpar - thoughts on merging this PR?