NVIDIA / apex

A PyTorch Extension: Tools for easy mixed precision and distributed training in Pytorch
BSD 3-Clause "New" or "Revised" License
8.2k stars 1.36k forks source link

Make distributed fused lamb test names friendly to keyword filtering #1698

Open crcrpar opened 1 year ago

crcrpar commented 1 year ago

This is merely cosmetic as the current parametrization creates test case names such as NcclDistributedFusedLAMB.test_distributed_fused_lamb_no_copy_True_opt_kwargs_{'overlap_reductions': False, 'dwu_num_blocks': 1, 'dwu_num_chunks': 1, 'fused_norm': True, 'fuse_scale': True, 'clip_after_ar': False} whic is not ideally friendly to keyword filtering.


it might be worth thinking of removing no_copy check here https://github.com/NVIDIA/apex/blob/f03c6fb67e51b7b8d499033196bb1559adc4e182/apex/contrib/optimizers/distributed_fused_lamb.py#L160-L166

cc @ptrblck @eqy @Aidyn-A