Open tlogn opened 2 months ago
@crcrpar thanks for your advise. I've added a test case and tested with H100.
with the main branch, error occurs:
Mismatched elements: 1866930499 / 2477260800 (75.4%)
Greatest absolute difference: nan at index (0, 0, 2146, 1184) (up to 0.04 allowed)
Greatest relative difference: nan at index (0, 0, 2146, 1184) (up to 0 allowed)
----------------------------------------------------------------------
Ran 16 tests in 8.897s
FAILED (failures=1)
with the fixed branch, the atol should be adjusted to 7e-2 to account for potential increased reduction accuracy error
................
----------------------------------------------------------------------
Ran 16 tests in 8.079s
OK
@crcrpar Hi there, is there any problem remained ?
This PR fix groupnorm int32 index calculate overflow when hwc is large, as hwc is of int data type. The problem could be reproduced by code below. @crcrpar please review, thanks !