search

NVIDIA / cccl

CUDA Core Compute Libraries
https://nvidia.github.io/cccl/
Other
1.32k stars 167 forks source link

Add tests for thrust::optional #1713

Open miscco opened 6 months ago

miscco commented 6 months ago

We realized that we do not have tests for thrust::optional in the repo.

We should add them

bernhardmgruber commented 4 months ago

I just stumbled over thrust::optional thinking: "This should be replaced by cuda::std::optional". Is there any reason why we cannot move to cuda::std::optional? If no, then we should at least deprecate thrust::optional and tell users to start migrating to cuda::std::optional.

bernhardmgruber commented 4 months ago

@miscco can we replace thrust::optional by cuda::std::optional when we move Thrust to C++17?

miscco commented 4 months ago

Technically not because thrust::optional also supports reference types

bernhardmgruber commented 4 months ago

I see. I guess we have to track progress on https://wg21.link/P2988 then and wait for ::cuda::std::optional<T&>.

miscco commented 4 months ago

I believe we should just do the right thing and implement it