Open davebayer opened 3 days ago
/ok to test
Given that we already need to run the full CI matrix, could you also replace all internal uses of the old macros with the new one?
Given that we already need to run the full CI matrix, could you also replace all internal uses of the old macros with the new one?
Which ones do you mean? If you mean use of [[deprecated]]
, sure, that's not a problem. However I cannot replace the definitions for individual parts (libcu++, thrust and cub) as each of them implement it's own deprecation suppression mechanism.
Yeah I meant the different libraries and we should define a common mechanism to suppress the deprecation warning
/ok to test
Looks like we need to ensure that _LIBCUDACXX_HIDE_FROM_ABI
always comes after any of the deprecation macros
It got a bit more complicated again :/
Current changes:
_CCCL_DEPRECATED
and _CCCL_DEPRECATED_BECAUSE
_CCCL_DEPRECATED_TYPE_ALIAS
and _CCCL_DEPRECATED_TYPE_ALIAS_BECAUSE
macros were added_LIBCUDACXX_DEPRECATED_IN_CXX11
was removed in favour of _LIBCUDACXX_DEPRECATED
After discussion with @miscco, we've decided to leave rework of suppressing cccl's deprecated suppression macros to a separate PR.
pre-commit.ci autofix
This PR moves implementation of
_CCCL_DEPRECATED
and_CCCL_DEPRECATED_BECAUSE
to CCCL.