NVIDIA / clara-dicom-adapter

DICOM Adapter is a component of the Clara Deploy SDK which facilitates integration with DICOM compliant systems, enables ingestion of imaging data, helps triggering of jobs with configurable rules and offers pushing the output of jobs to PACS systems.
https://nvidia.github.io/clara-dicom-adapter/
Apache License 2.0
37 stars 14 forks source link

Enforce Job Processor settings validation #17

Closed mocsharp closed 3 years ago

mocsharp commented 3 years ago

Description

The Clara Creaet AE Title Web API does not validate processor settings until it is loaded by the CRD watcher. PR introduces new ProcessorValidationAttribute attribute to decorate each derived JobProcessorBase class with a new IJobProcessorValidator interface to enforce validation when the API is called.

Status

Ready/Work in progress/Hold

Types of changes

github-actions[bot] commented 3 years ago

Unit Test Results

  2 files  ±0    2 suites  ±0   2m 6s :stopwatch: -5s 14 tests ±0  14 :heavy_check_mark: ±0  0 :zzz: ±0  0 :heavy_multiplication_x: ±0 

results for commit c94286e9 ± comparison against base commit 8e7ece6c

github-actions[bot] commented 3 years ago

Unit Test Results

  2 files  ±0    2 suites  ±0   2m 13s :stopwatch: +2s 14 tests ±0  14 :heavy_check_mark: ±0  0 :zzz: ±0  0 :heavy_multiplication_x: ±0 

results for commit c94286e9 ± comparison against base commit 8e7ece6c

github-actions[bot] commented 3 years ago

Unit Test Results

    7 files  +    5      7 suites  +5   6m 16s :stopwatch: + 4m 5s 184 tests +170  184 :heavy_check_mark: +170  0 :zzz: ±0  0 :heavy_multiplication_x: ±0 

results for commit a3e27793 ± comparison against base commit 8e7ece6c

github-actions[bot] commented 3 years ago

Unit Test Results

    7 files      7 suites   6m 14s :stopwatch: 184 tests 184 :heavy_check_mark: 0 :zzz: 0 :heavy_multiplication_x:

results for commit fa94802e

codecov-io commented 3 years ago

Codecov Report

Merging #17 into main will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##                main         #17   +/-   ##
=============================================
  Coverage   59.13940%   59.13940%           
=============================================
  Files             52          52           
  Lines           2812        2812           
  Branches         328         328           
=============================================
  Hits            1663        1663           
  Misses          1032        1032           
  Partials         117         117           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a9f8ff8...fa94802. Read the comment docs.

github-actions[bot] commented 3 years ago

Unit Test Results

  2 files  -    4    2 suites  -4   2m 13s :stopwatch: - 1m 26s 14 tests -140  14 :heavy_check_mark: -140  0 :zzz: ±0  0 :heavy_multiplication_x: ±0 

results for commit 7a0610b0 ± comparison against base commit a9f8ff8b

github-actions[bot] commented 3 years ago

Unit Test Results

    5 files  -  1      5 suites  -1   3m 39s :stopwatch: ±0s 170 tests +16  170 :heavy_check_mark: +16  0 :zzz: ±0  0 :heavy_multiplication_x: ±0 

results for commit 7a0610b0 ± comparison against base commit a9f8ff8b

github-actions[bot] commented 3 years ago

Unit Test Results

    7 files  +  1      7 suites  +1   6m 11s :stopwatch: + 2m 32s 184 tests +30  184 :heavy_check_mark: +30  0 :zzz: ±0  0 :heavy_multiplication_x: ±0 

results for commit 7a0610b0 ± comparison against base commit a9f8ff8b