NVIDIA / clara-dicom-adapter

DICOM Adapter is a component of the Clara Deploy SDK which facilitates integration with DICOM compliant systems, enables ingestion of imaging data, helps triggering of jobs with configurable rules and offers pushing the output of jobs to PACS systems.

https://nvidia.github.io/clara-dicom-adapter/

Apache License 2.0

37 stars 14 forks source link

Fix outdated configuration docs #33

Closed mocsharp closed 3 years ago

mocsharp commented 3 years ago

Description

Outdated configuration files and docs caused some settings to be ignored when loading.

Status

Ready

Types of changes

[x] Non-breaking change (fix or new feature that would not break existing functionality).
[ ] Breaking change (fix or new feature that would cause existing functionality to change).
[ ] New tests added to cover the changes.
[x] All tests passed locally by running ./src/run-tests-in-docker.sh.
[ ] Documentation comments included/updated.
[x] User guide updated.
[ ] NGC publishing metadata updated.
[ ] I have updated the changelog

github-actions[bot] commented 3 years ago

Unit Test Results

    7 files ±0     7 suites ±0 9m 0s :stopwatch: + 1m 39s 253 tests ±0 253 :heavy_check_mark: ±0 0 :zzz: ±0 0 :heavy_multiplication_x: ±0

results for commit 3d62c0e0 ± comparison against base commit 511e6d2e

github-actions[bot] commented 3 years ago

Unit Test Results

    7 files ±0     7 suites ±0 8m 36s :stopwatch: + 1m 15s 253 tests ±0 253 :heavy_check_mark: ±0 0 :zzz: ±0 0 :heavy_multiplication_x: ±0

results for commit 52cb8363 ± comparison against base commit 511e6d2e

github-actions[bot] commented 3 years ago

Unit Test Results

    7 files ±0     7 suites ±0 7m 4s :stopwatch: -17s 253 tests ±0 253 :heavy_check_mark: ±0 0 :zzz: ±0 0 :heavy_multiplication_x: ±0

results for commit ce93151e ± comparison against base commit 511e6d2e

codecov-io commented 3 years ago

Codecov Report

Merging #33 (511e6d2) into main (511e6d2) will not change coverage. The diff coverage is n/a.

@@              Coverage Diff              @@
##                main         #33   +/-   ##
=============================================
  Coverage   49.82928%   49.82928%           
=============================================
  Files             90          90           
  Lines           4979        4979           
  Branches         582         582           
=============================================
  Hits            2481        2481           
  Misses          2329        2329           
  Partials         169         169

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 511e6d2...ce93151. Read the comment docs.

github-actions[bot] commented 3 years ago

Unit Test Results

    7 files ±0     7 suites ±0 6m 54s :stopwatch: -27s 253 tests ±0 253 :heavy_check_mark: ±0 0 :zzz: ±0 0 :heavy_multiplication_x: ±0

results for commit 1f0cf491 ± comparison against base commit 511e6d2e