upgrade golangci-lint, run pre-commit in CI, add more pre-commit hooks - Githubissues

NVIDIA / container-canary

A tool for testing and validating container requirements against versioned manifests

Apache License 2.0

245 stars 15 forks source link

upgrade golangci-lint, run pre-commit in CI, add more pre-commit hooks #67

Closed jameslamb closed 3 months ago

jameslamb commented 3 months ago

On #65, I observed linting failing in CI even though pre-commit run --all-files passed for me locally.

Looks like that was because pre-commit isn't run in CI here. Instead, this third-party action is used:

https://github.com/NVIDIA/container-canary/blob/8f14a3e309788e5a1eb0901cf1559bf7bcfaf56f/.github/workflows/lint.yaml#L15-L16

This proposes the following:

update to the latest version of golangci-lint in pre-commit config
add a few more small pre-commit hooks (for trailing whitespace and newlines)
run pre-commit in CI