search

NVIDIA / dcgm-exporter

NVIDIA GPU metrics exporter for Prometheus leveraging DCGM
Apache License 2.0
923 stars 159 forks source link

Allow selecting the service's ClusterIP #375

Closed remram44 closed 2 weeks ago

remram44 commented 3 months ago

This is mostly useful to be able to set it to "None", creating a headless service that can be scraped using DNS discovery (dns_sd_configs).

No change in default behavior.

remram44 commented 3 weeks ago

Bump

glowkey commented 3 weeks ago

The commit needs to be signed (git commit -S) before it can be merged.

remram44 commented 3 weeks ago

The commit is signed-off (git commit -s) as requested by your contributing guide.

glowkey commented 2 weeks ago

Sorry for the confusion. The contribution guide needs to be updated as the repository rules prevent us from merging commits that have not been signed with "git commit -S".

rules
remram44 commented 2 weeks ago

Please fix your contributing guide ASAP, a guide with the wrong instructions is worse than no guide at all.

I signed the commit so you can be sure the owner of this GitHub account is the owner of this GitHub account... really confused as to what this does for security, but here you go.

glowkey commented 2 weeks ago

We've asked the admins to change this rule to make future contributions easier. Thanks for your help!