search

NVIDIA / dcgm-exporter

NVIDIA GPU metrics exporter for Prometheus leveraging DCGM
Apache License 2.0
923 stars 159 forks source link

fix: edit gitignore and require dir & file #382

Closed kschoi93 closed 2 months ago

kschoi93 commented 2 months ago

Set the "/cmd/dcgm-exporter" folder, which must be included, in gitignore.

Please refer to the issue contents

381

glowkey commented 2 months ago

I could not reproduce #381 on a fresh OS instance. We do not plan to merge this at it seems very specific to your environment.

kschoi93 commented 2 months ago

@glowkey. You're probably working on a forked repository. If you've done "git clone" -> "another git repo init" -> "git add .", you've probably realized that the problem was caused by incorrect .gitignore usage.

cmd_not_added

And you can see that cmd is included when the string I wrote is added to .gitignore.

add gitignore
kschoi93 commented 2 months ago

You may ask why I clone the original git repository of dcgm exporter instead of doing git fork & clone. If you do git clone, there is an example in the README. If you use that example to develop and do git push to the git repository you created, you may get the same error I wrote about.

building from source
kschoi93 commented 2 months ago

@glowkey Please confirm again.

glowkey commented 2 months ago

No, we do not plan on making this change. Please fork your own repository if you're attempting to make changes.

kschoi93 commented 2 months ago

Since you can't reproduce the problem, I personally proved that it occurs in certain cases and that it is not limited to my specific environment. The problem is that you are using gitignore incorrectly in this project, and I asked you to fix it. I don't understand why you don't fix it when you can see that your gitignore is incorrect just by looking at the image, not the text above.