search

NVIDIA / dcgm-exporter

NVIDIA GPU metrics exporter for Prometheus leveraging DCGM
Apache License 2.0
923 stars 159 forks source link

Fix Helm Templates Generation #406

Closed Indresh2410 closed 3 weeks ago

Indresh2410 commented 3 weeks ago

Issue: https://github.com/NVIDIA/dcgm-exporter/issues/405

glowkey commented 3 weeks ago

The commit needs to be signed (git commit -S) before it can be merged.

Indresh2410 commented 3 weeks ago

Hi @glowkey . Thanks for reviewing. The commit is already signed https://github.com/NVIDIA/dcgm-exporter/pull/406/commits/2554e4cee39e63378b68e4179dc81109a58800aa

Not sure if we are missing something here. Can you please help here?

glowkey commented 3 weeks ago

Check out this link: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification If you look at your commit, you'll notice it does not have the "Verified" tag.

Indresh2410 commented 3 weeks ago

Thanks @glowkey . Addressed it. Thanks for pointing out 😄 . If there are no issues, can we please merge the PR?