NVIDIA / earth2mip

Earth-2 Model Intercomparison Project (MIP) is a python framework that enables climate researchers and scientists to inter-compare AI models for weather and climate.

https://nvidia.github.io/earth2mip/

Apache License 2.0

187 stars 41 forks source link

DLWP scoring fixes #139

Closed ktangsali closed 9 months ago

ktangsali commented 9 months ago

Earth-2 MIP Pull Request

Description

Fixes the bug in the time shift code in dlwp wrapper. Also adds more comments to the scoring notebook for better clarity.

Closes https://github.com/NVIDIA/earth2mip/issues/140

Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[ ] The documentation is up to date with these changes.
[ ] The CHANGELOG.md is up to date with these changes.
[ ] An issue is linked to this pull request.

Dependencies

ktangsali commented 9 months ago

/blossom-ci

ktangsali commented 9 months ago

/blossom-ci

NickGeneva commented 9 months ago

/blossom-ci

NickGeneva commented 9 months ago

Merged here: https://github.com/NVIDIA/earth2mip/pull/146

Thanks for fixing this!