NVIDIA / earth2mip

Earth-2 Model Intercomparison Project (MIP) is a python framework that enables climate researchers and scientists to inter-compare AI models for weather and climate.
https://nvidia.github.io/earth2mip/
Apache License 2.0
187 stars 41 forks source link

add scale and center to model perturb examples #87

Closed yairchn closed 10 months ago

yairchn commented 10 months ago

Earth-2 MIP Pull Request

Description

This PR adds a file that was not committed in PR77 and closes issue #84 by applying source to both dimensional and non dimensional state vectors

Checklist

Dependencies

yairchn commented 10 months ago

/blossom-ci

yairchn commented 10 months ago

/blossom-ci

yairchn commented 10 months ago

/blossom-ci

yairchn commented 10 months ago

/blossom-ci

nbren12 commented 10 months ago

Also gives this error:

Traceback (most recent call last):
  File "/home/nbrenowitz/workspace/earth2mip/examples/workflows/run_ensemble_model_noise.py", line 93, in <module>
    main()
  File "/home/nbrenowitz/workspace/earth2mip/examples/workflows/run_ensemble_model_noise.py", line 89, in main
    run_inference(model, config, perturb, group)
  File "/home/nbrenowitz/workspace/earth2mip/earth2mip/inference_ensemble.py", line 382, in run_inference
    run_ensembles(
  File "/home/nbrenowitz/workspace/earth2mip/earth2mip/inference_ensemble.py", line 131, in run_ensembles
    for k, (time, data, _) in enumerate(iterator):
  File "/usr/local/lib/python3.10/dist-packages/tqdm/std.py", line 1182, in __iter__
    for obj in iterable:
  File "/home/nbrenowitz/workspace/earth2mip/earth2mip/networks/__init__.py", line 210, in __call__
    yield from self._iterate(x=x, time=time)
  File "/home/nbrenowitz/workspace/earth2mip/earth2mip/networks/__init__.py", line 238, in _iterate
    x += self.source(x_with_units, time) / self.scale * dt
TypeError: generate_model_noise_correlated() got an unexpected keyword argument 'model'
nbrenowitz@fb7510c-lcedt:~/workspace/earth2mip$ 
yairchn commented 10 months ago

/blossom-ci