search

NVIDIA / earth2studio

Open-source deep-learning framework for exploring, building and deploying AI weather/climate workflows.
https://nvidia.github.io/earth2studio/
Apache License 2.0
73 stars 23 forks source link

🚀[FEA]: Change input_coords to function that returns new dictionary #77

Closed NickGeneva closed 2 months ago

NickGeneva commented 2 months ago

Is this a new feature, an improvement, or a change to existing functionality?

Improvement

How would you describe the priority of this feature request

Medium

Please provide a clear description of problem you would like to solve.

Improve input_coords handling.

Presently a property this is:

  1. inconsistent with new updated output coords function
  2. Error prone as users can edit the input coord property of a component inplace accidently

Proposed change:

Update the input coords to a function that returns a new dictionary every time its called:

def input_coords(self) -> CoordSystem:
        """Input coordinate system of prognostic model, time dimension should contain
        time-delta objects

        Returns
        -------
        CoordSystem
            Coordinate system dictionary
        """
        pass