Fail cloning repo

[albertbu]

Hi all, I am not able to clone the repo. I follow all the instructions as in "building without docker" and edkrepo clone nvidia-uefi NVIDIA-Platforms main asks me for a github user. When I try to enter my github user and passwrod, it rejects it. Any help? I'm compiling on WSL2, and in the past everything worked well

[jgarver]

Hi, @albertbu. Is it complaining about a specific repo?

[marioal9806]

Hi! @jgarver I'm also facing an issue when cloning the forked repos, except that I'm trying with r36.3.0 combo. The command I'm running is edk2_docker edkrepo clone nvidia-uefi NVIDIA-Platforms r36.3.0. The offending repo looks to be https://github.com/Zeex/subhook.git/. When opening it on my explorer, I get a 404 error. That user seems to be listed as a private user.

I attach some of the logs from my edkrepo command:

Verifying the global manifest repository entry for project: NVIDIA-Platforms

Cloning from: https://github.com/NVIDIA/edk2.git
Cloning from: https://github.com/NVIDIA/edk2-non-osi.git
Cloning from: https://github.com/NVIDIA/edk2-platforms.git
Cloning from: https://github.com/NVIDIA/edk2-nvidia.git
Cloning from: https://github.com/NVIDIA/edk2-nvidia-non-osi.git
Cloning from: https://github.com/NVIDIA/open-gpu-kernel-modules.git
Initializing/Updating submodules311), done.
Username for 'https://github.com':
Password for 'https://github.com':
Username for 'https://github.com':
Password for 'https://github.com':
The git command: git submodule update --init failed to complete successfully with the following errors.

stderr: 'Submodule 'SoftFloat' (https://github.com/ucb-bar/berkeley-softfloat-3.git) registered for path 'ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3'
Submodule 'BaseTools/Source/C/BrotliCompress/brotli' (https://github.com/google/brotli) registered for path 'BaseTools/Source/C/BrotliCompress/brotli'
Submodule 'CryptoPkg/Library/MbedTlsLib/mbedtls' (https://github.com/ARMmbed/mbedtls) registered for path 'CryptoPkg/Library/MbedTlsLib/mbedtls'
Submodule 'CryptoPkg/Library/OpensslLib/openssl' (https://github.com/openssl/openssl) registered for path 'CryptoPkg/Library/OpensslLib/openssl'
Submodule 'MdeModulePkg/Library/BrotliCustomDecompressLib/brotli' (https://github.com/google/brotli) registered for path 'MdeModulePkg/Library/BrotliCustomDecompressLib/brotli'
Submodule 'MdeModulePkg/Universal/RegularExpressionDxe/oniguruma' (https://github.com/kkos/oniguruma) registered for path 'MdeModulePkg/Universal/RegularExpressionDxe/oniguruma'
Submodule 'MdePkg/Library/BaseFdtLib/libfdt' (https://github.com/devicetree-org/pylibfdt.git) registered for path 'MdePkg/Library/BaseFdtLib/libfdt'
Submodule 'MdePkg/Library/MipiSysTLib/mipisyst' (https://github.com/MIPI-Alliance/public-mipi-sys-t.git) registered for path 'MdePkg/Library/MipiSysTLib/mipisyst'
Submodule 'RedfishPkg/Library/JsonLib/jansson' (https://github.com/akheron/jansson) registered for path 'RedfishPkg/Library/JsonLib/jansson'
Submodule 'UnitTestFrameworkPkg/Library/CmockaLib/cmocka' (https://github.com/tianocore/edk2-cmocka.git) registered for path 'UnitTestFrameworkPkg/Library/CmockaLib/cmocka'
Submodule 'UnitTestFrameworkPkg/Library/GoogleTestLib/googletest' (https://github.com/google/googletest.git) registered for path 'UnitTestFrameworkPkg/Library/GoogleTestLib/googletest'
Submodule 'UnitTestFrameworkPkg/Library/SubhookLib/subhook' (https://github.com/Zeex/subhook.git) registered for path 'UnitTestFrameworkPkg/Library/SubhookLib/subhook'
Cloning into '/****/edk2/ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3'...
Cloning into '/****/edk2/BaseTools/Source/C/BrotliCompress/brotli'...
Cloning into '/****/edk2/CryptoPkg/Library/MbedTlsLib/mbedtls'...
Cloning into '/****/edk2/CryptoPkg/Library/OpensslLib/openssl'...
Cloning into '/****/edk2/MdeModulePkg/Library/BrotliCustomDecompressLib/brotli'...
Cloning into '/****/edk2/MdeModulePkg/Universal/RegularExpressionDxe/oniguruma'...
Cloning into '/****/edk2/MdePkg/Library/BaseFdtLib/libfdt'...
Cloning into '/****/edk2/MdePkg/Library/MipiSysTLib/mipisyst'...
Cloning into '/****/edk2/RedfishPkg/Library/JsonLib/jansson'...
Cloning into '/****/edk2/UnitTestFrameworkPkg/Library/CmockaLib/cmocka'...
Cloning into '/****/edk2/UnitTestFrameworkPkg/Library/GoogleTestLib/googletest'...
Cloning into '/****/edk2/UnitTestFrameworkPkg/Library/SubhookLib/subhook'...
remote: Repository not found.
fatal: Authentication failed for 'https://github.com/Zeex/subhook.git/'
fatal: clone of 'https://github.com/Zeex/subhook.git' into submodule path '/****/nvidia-uefi/edk2/UnitTestFrameworkPkg/Library/SubhookLib/subhook' failed
Failed to clone 'UnitTestFrameworkPkg/Library/SubhookLib/subhook'. Retry scheduled
Cloning into '/****/nvidia-uefi/edk2/UnitTestFrameworkPkg/Library/SubhookLib/subhook'...
remote: Repository not found.
fatal: Authentication failed for 'https://github.com/Zeex/subhook.git/'
fatal: clone of 'https://github.com/Zeex/subhook.git' into submodule path '/****/nvidia-uefi/edk2/UnitTestFrameworkPkg/Library/SubhookLib/subhook' failed
Failed to clone 'UnitTestFrameworkPkg/Library/SubhookLib/subhook' a second time, aborting'

[jgarver]

Thanks, @marioal9806. That's very helpful.

Looks like it's an issue upstream, too: https://github.com/tianocore/edk2/pull/6402

I'll watch that PR. When it has been merged, we'll backport it to our fork.

In the meantime, I'll try to find a work-around.

[jgarver]

Here's a work-around. Basically, it's 1) clone without submodules, 2) fix the submodule, 3) fetch submodules.

edk2_docker edkrepo clone nvidia-uefi NVIDIA-Platforms r36.3.0 -s
cd nvidia-uefi/edk2
# edit .gitmodules and change subhook URL to https://github.com/tianocore/edk2-subhook.git
git commit -a -m "Fix subhook url"
git submodule init
git submodule update

Even after I have a fix, you'll need this work-around for tagged combos (e.g. r36.3.0), but I'll be able to fix our update combos (e.g. r36.3.0-updates) so you can clone as before.

[marioal9806]

The workaround did the trick. Thanks @jgarver 💯

[jgarver]

This is what we'll use for the long-term fix. https://github.com/NVIDIA/edk2-edkrepo-manifest/pull/47

This avoids updating all the branches.

The edk2 fix has been merged. We'll deliver that to our fork as part of our next release.