search

NVIDIA / edk2-nvidia

NVIDIA EDK2 platform support
Other
78 stars 36 forks source link

Fix error with no serial ports configured on T194 #68

Closed jmbaur closed 1 year ago

jmbaur commented 1 year ago

The behavior of UpdateSerialPortInfo for the T234 differs from that of the T194. When all serial ports are disabled on the T234, DSDT is not patched with serial port info and the ConfigurationManager DXE resumes as normal. When this is the case on the T194, the error bubbles up to the top of ConfigurationManager's entrypoint, causing many further configuration tables to not be populated (SMBIOS being one of them).

bobm21 commented 1 year ago

@jmbaur Thanks for this patch, it looks good. Please update the commit message:

a) We use a "<fix/chore/feat>:" prefix on title, e.g. yours would be "fix(t194): ". Please limit the total title line to 80 chars.</p> <p>b) limit description to 100 chars per line, any number of lines.</p> <p>c) add signed-off-by tag</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/bobm21"><img src="https://avatars.githubusercontent.com/u/89551112?v=4" />bobm21</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Merged into r35.4.1-updates branch with <a href="https://github.com/NVIDIA/edk2-nvidia/pull/72">https://github.com/NVIDIA/edk2-nvidia/pull/72</a></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/jbrasen"><img src="https://avatars.githubusercontent.com/u/7462596?v=4" />jbrasen</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Released in edk2-nvidia-202308.0</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>