NVIDIA / egl-wayland

The EGLStream-based Wayland external platform
MIT License
275 stars 43 forks source link

egl-wayland: Validate and use the passed value of EGL_EXT_present_opaque #109

Closed Kontrabant closed 1 week ago

Kontrabant commented 1 month ago

It was assumed that the presence of the EGL_PRESENT_OPAQUE_EXT enum in the surface attribute list meant that the alpha channel should be ignored as if it was always followed by a value of EGL_TRUE, however, according to the spec, valid usage allows for a value of EGL_FALSE as well, which should result in the alpha channel being used for blending.

Validate and use the value instead of assuming that the presence of the extension enum value implies that it is enabled.

erik-kz commented 1 month ago

Thanks for the patch, it looks good to me. Just need a +1 from another NVIDIA engineer, @amshafer would you be able to take a look?

amshafer commented 1 month ago

Looks good to me as well, thanks