search

NVIDIA / egl-wayland

The EGLStream-based Wayland external platform
MIT License
275 stars 44 forks source link

Add eglmesaext.h include in wayland-eglsurface.c #24

Closed B4dM4n closed 4 years ago

B4dM4n commented 4 years ago

eglmesaext.h was previously included via eglext.h but mesa stopped providing GLVND headers in mesa-19.2.2. Without eglmesaext.h EGL_WAYLAND_Y_INVERTED_WL is not defined and wayland-eglsurface.c` fails to compile.

../src/wayland-eglsurface.c: In function 'wlEglQueryNativeResourceHook':
../src/wayland-eglsurface.c:1523:10: error: 'EGL_WAYLAND_Y_INVERTED_WL' undeclared (first use in this function); did you mean 'EGL_WAYLAND_EGLSTREAM_WL'?
     case EGL_WAYLAND_Y_INVERTED_WL:
          ^~~~~~~~~~~~~~~~~~~~~~~~~
          EGL_WAYLAND_EGLSTREAM_WL
../src/wayland-eglsurface.c:1523:10: note: each undeclared identifier is reported only once for each function it appears in
mvicomoya commented 4 years ago

@B4dM4n thanks for the PR!

Rather than including EGL/eglmesaext.h, I suggest adding EGL_WAYLAND_Y_INVERTED_WL to https://github.com/NVIDIA/egl-wayland/blob/master/wayland-egl/wayland-egl-ext.h so that we don't create a dependency for EGL/eglmesaext.h.

I can make that change if you cannot make amends to this PR.

mvicomoya commented 4 years ago

@ekurzinger you might want to follow-up on this :-)

tpgxyz commented 4 years ago

I've prepared RP #26 egl-wayland compiles and runs fine on OpenMandriva Linux

erik-kz commented 4 years ago

This fix should no longer be needed as of https://github.com/NVIDIA/egl-wayland/commit/4a343a4b563e84c6258efbddf1d910f9dd6e0300, which adds the EGL_WL_bind_wayland_display extension block to wayland-egl-ext.h, providing the missing enum definition.