NVIDIA / egl-wayland

The EGLStream-based Wayland external platform
MIT License
275 stars 43 forks source link

Fix wrong destruction order for event queue #79

Closed q234rty closed 1 year ago

q234rty commented 1 year ago

libwayland 1.22 added a warning that could currently be triggered by running eglgears_wayland under NVIDIA wayland:

warning: queue 0x5560c4ce1b30 destroyed while proxies still attached:
  wl_registry@3 still attached

Firefox currently crashes upon such warnings. Mesa has fixed a similar bug in https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21646

AlynxZhou commented 1 year ago

I tested this with a NVIDIA 2070 Super using nvidia driver, it fixes the warning.

colemickens commented 1 year ago

Ping, if this can be merged/tagged it would be great. It's currently potentially blocking distro(s) that want to update libwayland.

erik-kz commented 1 year ago

Thanks. This looks good to me. Will merge after getting +1 from another NVIDIA engineer.