search

NVIDIA / fsi-samples

A collection of open-source GPU accelerated Python tools and examples for quantitative analyst tasks and leverages RAPIDS AI project, Numba, cuDF, and Dask.
271 stars 115 forks source link

[REVIEW]asian barrier option tutorial #77

Closed yidong72 closed 4 years ago

yidong72 commented 4 years ago
avolkov1 commented 4 years ago

@yidong72 Could you please rebase this PR's feature-option branch with develop branch to resolve conflicts? Currently this PR has a bunch of changes already performed in PR #76.

yidong72 commented 4 years ago

merged the develop branch

avolkov1 commented 4 years ago

Can you upload the files "model_best.pth.tar" to data.world like you did with "stock_price_hist.csv.gz" and add a script or code to download the models as needed when running the notebooks?

yidong72 commented 4 years ago

I move the checkpoint files to the data.world and added the script to download them

yidong72 commented 4 years ago

now ready for the next around of review

yidong72 commented 4 years ago

fixed an issue to make sure deep learning notebook 2 work

yidong72 commented 4 years ago

These are very good comments. I incorporate them into this new commit.

yidong72 commented 4 years ago

Added some comments to explain what it takes to train a good model.

yidong72 commented 4 years ago

Fixed the typoes