Closed yidong72 closed 4 years ago
I did the rebase as you suggested.
Checked in the last feature for this PR. When making new connections, it can dynamically show who are the valid ports for this connection.
Please update the changelog in order to start CI tests.
View the gpuCI docs here.
I addressed all your comments. I added a workspace file so that both server and client project can be simultaneously opened up in the VSCode inside the container. I put the detailed instructions in the README file. I added the file manager to load the yaml files.
I did a few changes:
Please hold off on merging other PRs into this PR until the other PRs are closed. This confuses the commits history (making it hard to review), will cause rebase conflicts which can cause bugs fixes in other PRs not getting merged properly. This branch will need to be rebased to clean up the commits and make sure to fix bugs during merge conflicts.
Let's clean up this branch. I would make a copy backup of the local repo directory while in branch-client
just in case something goes missing.
Use the following commands:
$ git checkout branch-client
# ghub-gquant is my remote name for: git@github.com:rapidsai/gQuant.git
$ git rebase -Xours ghub-gquant/develop
$ git rebase -i 5d53970
During rebase -i 5d53970
you'll see a list of commits. Keep only the following ones:
pick 0884fc8 make the code 0.13 compatible
pick 73f394c :# This is a combination of 2 commits.
pick 1f7db16 fixed the flake error
pick 5d8c9b6 feed the type to the client
pick e34598f now check the types of the port
pick 20035d2 fixed the missing line issue
pick 3972ebf use firefox to debug
pick 50f2a2e save the workflow in disk
pick b66ce5d try new workspace
The SHAs might differ. I believe the above ones are the only relevant ones for this branch. Delete the other lines. Doing above I did not get any conflicts and commits from develop were properly applied.
Then do a push force.
$ git push --force
Let's clean up this branch. I would make a copy backup of the local repo directory while in
branch-client
just in case something goes missing.Use the following commands:
$ git checkout branch-client # ghub-gquant is my remote name for: git@github.com:rapidsai/gQuant.git $ git rebase -Xours ghub-gquant/develop $ git rebase -i 5d53970
During
rebase -i 5d53970
you'll see a list of commits. Keep only the following ones:pick 0884fc8 make the code 0.13 compatible pick 73f394c :# This is a combination of 2 commits. pick 1f7db16 fixed the flake error pick 5d8c9b6 feed the type to the client pick e34598f now check the types of the port pick 20035d2 fixed the missing line issue pick 3972ebf use firefox to debug pick 50f2a2e save the workflow in disk pick b66ce5d try new workspace
The SHAs might differ. I believe the above ones are the only relevant ones for this branch. Delete the other lines. Doing above I did not get any conflicts and commits from develop were properly applied.
Then do a push force.
$ git push --force
Thanks. I follwed the instruction and fixed the commits in this branch. It works fine.
I finished the work of migrating the UI to Jupyterlab ecosystem. The user can select a set of output ports from the UI and run it in a notebook cell. Check the test.ipynb
notebook for examples.
Addressed your two comments
I switched to the configparser
library, added the optional 'module' field to the node so that it can load the exact class from the specified module name. If no 'module' is set, it will scan through all the modules specified in the gquantrc
file. I also default the GQUANT_PATH
to be os.getcwd()+/gquantrc
and MODULEPATH
to be os.getcwd()+/modules/
all the gQuant nodes are migrated
Issue #95 and #97 are all addressed in this PR. It is ready to review and merge
done with the API clean up and removed the unused method
sorry. For some reason I missed a few comments in the last review. I just went through them all
In this PR, it added