search

NVIDIA / go-dcgm

Golang bindings for Nvidia Datacenter GPU Manager (DCGM)
Apache License 2.0
96 stars 27 forks source link

Updates for DCGM 3.3.0 #45

Closed glowkey closed 1 year ago

glowkey commented 1 year ago

Also includes fix/formatting for WatchPidFields from helinfan

rswhollan commented 1 year ago

Have you looked at testing/python3/internal_scripts/nvswitch_counter_monitor.py? It uses some of the fields you are deleting. Well, from the python equivalent of dcgm_fields.h, but that should follow dcgm_fields.h.

glowkey commented 1 year ago

The deleted fields are no longer present in dcgm_fields.h. Most likely nvswitch_counter_monitor.py needs to be updated.

rswhollan commented 1 year ago

No, more than that: dcgm_fields.py has to match dcgm_fields.h. I did not see it in your merge request. Nik: this looks incomplete.

nikkon-dev commented 1 year ago

No, more than that: dcgm_fields.py has to match dcgm_fields.h. I did not see it in your merge request. Nik: this looks incomplete.

This is not the dcgm repo. The changes you are referring to are irrelevant for Go bindings.