search

NVIDIA / go-nvml

Go Bindings for the NVIDIA Management Library (NVML)
Apache License 2.0
311 stars 64 forks source link

Fix a minor memory leak in `pkg/dl` #32

Closed chenhengqi closed 2 years ago

chenhengqi commented 2 years ago

@klueska @elezar Please take a look.

elezar commented 2 years ago

Thanks for the change @chenhengqi. This is a good catch. Would it be possible to split this PR into one that addresses the memory leak and one that introduces the idiomatic names for the constants (or at least have these as separate commits)?

chenhengqi commented 2 years ago

I've just updated the changes to separate commit.

If this PR get merged to master, I hope you can also release a new tag so that I can vendor it locally. Thanks.

chenhengqi commented 2 years ago

@elezar @klueska

Hello, I just keep the first two commits of the original PR.