NVIDIA / gpu-feature-discovery

GPU plugin to the node feature discovery for Kubernetes
Apache License 2.0
292 stars 47 forks source link

Don't label product name or memory if more than one product type present #13

Closed robertdavidsmith closed 3 years ago

robertdavidsmith commented 3 years ago

Currently, gpu-feature-discovery assumes that all GPUs attached to a node are identical. Sadly this assumption isn't valid for a few of our nodes. These nodes have a mix of 16GB and 32GB V100s. Gpu-feature-discovery only examines the first GPU, so will label our mixed nodes as having 32GB if the first GPU does, regardless of other GPUs.

This PR examines all GPUs, and doesn't label product type or memory if there is more than one distinct product types. Users who don't care about these details can still match against the node, and those that do care won't.

cloud-native-bot[bot] commented 3 years ago

Hello There!

Thanks for your contribution! This repository is a read-only mirror of the following repository: https://gitlab.com/nvidia/kubernetes/gpu-feature-discovery

Do you mind:

Thanks again!

robertdavidsmith commented 3 years ago

Replaced with https://gitlab.com/nvidia/kubernetes/gpu-feature-discovery/-/merge_requests/73