search

NVIDIA / gpu-feature-discovery

GPU plugin to the node feature discovery for Kubernetes
Apache License 2.0
292 stars 47 forks source link

Chart template error due to hard coded value #39

Closed tonygilkerson closed 1 year ago

tonygilkerson commented 1 year ago

I found a hard coded value here in the chart.

I think you want this instead

# Before (bug)
{{- if typeIs "bool" .Values.nfd.enableNodeFeatureApi }}
  - name: GFD_USE_NODE_FEATURE_API
    value: "true" #<--- Hard code
{{- end }}

# After
{{- if typeIs "bool" .Values.nfd.enableNodeFeatureApi }}
  - name: GFD_USE_NODE_FEATURE_API
    value: {{ .Values.nfd.enableNodeFeatureApi | quote }}
{{- end }}
elezar commented 1 year ago

cc @ArangoGutierrez

ArangoGutierrez commented 1 year ago

Will fix in tandem with the update of NFD charts to v0.13

ArangoGutierrez commented 1 year ago

https://gitlab.com/nvidia/kubernetes/gpu-feature-discovery/-/merge_requests/165

elezar commented 1 year ago

Hi @tonygilkerson. This should have been addressed in the v0.8.1 release. Could you confirm that this is resolved?

tonygilkerson commented 1 year ago

Yes, I just installed v0.8.1 and that did resolve the issue. You can close this issue. Thanks