search

NVIDIA / gpu-monitoring-tools

Tools for monitoring NVIDIA GPUs on Linux
Apache License 2.0
1.02k stars 301 forks source link

dcgm-exporter gpu_collector_test.go's NewDCGMCollector broken #173

Open shatil opened 3 years ago

shatil commented 3 years ago

This unit test is broken on master and on tag 2.3.0. I had to delete the kubernetes_test.go file, which pulls in some exotic Kubernetes deps #172 to get the tests to run.

% go test ./...
go: finding module for package k8s.io/kubernetes/pkg/kubelet/apis/podresources/v1alpha1
go: finding module for package k8s.io/kubernetes/pkg/kubelet/util
go: found k8s.io/kubernetes/pkg/kubelet/util in k8s.io/kubernetes v1.20.5
go: k8s.io/kubernetes@v1.20.5 requires
    k8s.io/api@v0.0.0: reading k8s.io/api/go.mod at revision v0.0.0: unknown revision v0.0.0

% rm kubernetes_test.go 

% go test ./...        
# dcgm-exporter [dcgm-exporter.test]
./gpu_collector_test.go:43:37: not enough arguments in call to NewDCGMCollector
    have ([]Counter)
    want ([]Counter, bool)
FAIL    dcgm-exporter [build failed]
FAIL