search

NVIDIA / gvdb-voxels

Sparse volume compute and rendering on NVIDIA GPUs
Other
672 stars 144 forks source link

Use fabsf where input is a float32 #104

Closed mehmetoguzderin closed 3 years ago

mehmetoguzderin commented 3 years ago

This PR unifies all absolute value usage where input is a float32 to be fabsf, replacing fabs use at places.

NBickford-NV commented 3 years ago

Hi Mehmet! Sorry for the long wait - we just changed the license on GVDB in order to accept pull requests. If you're up for contributing this to GVDB, could you sign-off on your commits by going to your branch, then running

git rebase HEAD~2 --signoff

followed by

git push --force-with-lease

? This should add a line to each of the commit messages like this:

Signed-off-by: Contributor Name <email>

Once that's done, I can accept the pull request. Thanks!

mehmetoguzderin commented 3 years ago

@NeilBickford-NV Sure thing, congrats on the new licensing! Did the steps on this branch!

NBickford-NV commented 3 years ago

Perfect, merged! Thanks for helping out with this!

mehmetoguzderin commented 3 years ago

Have a great week, thanks for maintaining GVDB!