Update HDF5 base URL - Githubissues

NVIDIA / hpc-container-maker

HPC Container Maker

Apache License 2.0

458 stars 94 forks source link

Update HDF5 base URL #489

Closed twsearle closed 3 months ago

twsearle commented 3 months ago

Pull Request Description

Update HDF5 download URL.

Fixes NVIDIA/hpc-container-maker/issues/488

Testing

Run:

wget -q -nc --no-check-certificate https://support.hdfgroup.org/ftp/HDF5/releases/hdf5-1.14/hdf5-1.14.2/src/hdf5-1.14.2.tar.bz2
file hdf5-1.14.2.tar.bz2

Author Checklist

[ ] Updated documentation (pydocmd generate) if any docstrings have been modified
[ ] Passes all unit tests

samcmill commented 3 months ago

The change itself looks good, but can you please also update the unit tests?

twsearle commented 3 months ago

The change itself looks good, but can you please also update the unit tests?

Sure, apologies, I didn't spot the tests!

samcmill commented 3 months ago

Thank you for the fix!