search

NVIDIA / jitify

A single-header C++ library for simplifying the use of CUDA Runtime Compilation (NVRTC).
BSD 3-Clause "New" or "Revised" License
518 stars 64 forks source link

LONG_MAX fix #126

Closed EnaAlogo closed 1 year ago

EnaAlogo commented 1 year ago

LONG_MAX is not unsigned 4294967295 , this has been giving me a narrowing conversion error when trying to use the cub block_reduce header.

benbarsdell commented 1 year ago

Thanks! (I guess you're on Windows?)

If you want to you can open a PR with the same fix for jitify2: https://github.com/NVIDIA/jitify/blob/jitify2/jitify2.hpp#L3926

EnaAlogo commented 1 year ago

Okay i will do that now , also yes i am on Windows.