search

NVIDIA / jitify

A single-header C++ library for simplifying the use of CUDA Runtime Compilation (NVRTC).
BSD 3-Clause "New" or "Revised" License
518 stars 64 forks source link

Jitify compile doesn't parse numbers with separators and suffix correctly #135

Open pmattione-nvidia opened 6 months ago

pmattione-nvidia commented 6 months ago

Describe the bug The jitify compile doesn't parse numbers with separators and suffix correctly. For example, "1'000ULL".

Steps/Code to reproduce bug This can be reproduced by using a number like this in a header used by the jitify compilation, such as fixed_point.hpp in the cuDF library.

benbarsdell commented 6 months ago

Thanks, I've pushed a fix to https://github.com/NVIDIA/jitify/pull/131 (is that the branch you're using?)

(I had actually fixed this already but forgot to push it).

pmattione-nvidia commented 6 months ago

Great! Thanks.