search

NVIDIA / k8s-device-plugin

NVIDIA device plugin for Kubernetes
Apache License 2.0
2.48k stars 577 forks source link

Simplify and improve compatibility of PCI device classes for NFD workers #638

Closed rptaylor closed 1 month ago

rptaylor commented 1 month ago

Refer to https://kubernetes-sigs.github.io/node-feature-discovery/v0.15/reference/worker-configuration-reference#sourcespci

"02" means "02*" so the other entries starting with 02 are redundant.

Also improve compatibility by detecting all "03" types of display controllers, not just "0302". Refer to: https://admin.pci-ids.ucw.cz/read/PD/03

Also note that the default value of upstream NFD includes "03", as in this merge request. So this will improve compatibility and bring the behaviour in line with the standard defaults of upstream NFD. This way users can have the same standard expected behaviour whether they use NFD which is bundled in the NVIDIA device plugin, or upstream NFD.

ArangoGutierrez commented 1 month ago

Hey @rptaylor thanks for the contribution, please sign off your commit so we can move forward with the process

rptaylor commented 1 month ago

@elezar Looks like the DCO test is successful now.

klueska commented 1 month ago

@ArangoGutierrez ball is in your court