NVIDIA / k8s-device-plugin

NVIDIA device plugin for Kubernetes
Apache License 2.0
2.45k stars 573 forks source link

use the helm quote function to wrap helm values in quotes #644

Open tariq1890 opened 1 month ago

tariq1890 commented 1 month ago

It's generally recommended to use the quote function instead of explicitly wrapping helm values with quotes in-line

klueska commented 1 month ago

I'm not necessarily opposed to this, just curious is there there is any magic going on with doing things this way. Do all double quotes within the string being passed to quote get escaped, for example?