Closed dependabot[bot] closed 3 weeks ago
Looks like a breaking change was introduced to the new go-nvml lib. We should reconsider the semver bumps when we introduce interface changes IMO
@tariq1890 the semver in the go-nvml
package is tied to the CUDA version from which the wrappers are generated. We don't follow semver for this dependency.
Bumps github.com/NVIDIA/go-nvml from 0.12.0-3 to 0.12.0-4.
Commits
1fa43fd
Replace Library interface with Extensions interfaced72aa68
Add a mock DGXA100 server that implements parts of the NVML interface9a1711a
Add mocks for all interfaces under pkg/nvml/mock6f20742
Add ability to generate interfaces and package methods from libraryb34e706
Ensure that exported structs reference interface types not private typesf01937e
Fix API call for GetVgpuCompatibility3d3e863
Convert all uppercase local variables to lowercase80b4064
Convert GpmSample into an interface instead of a concrete type630d5a6
Fix API call for GpmSampleAllocfbdfe74
Convert ComputeInstance into an interface instead of a concrete typeDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show