search

NVIDIA / k8s-device-plugin

NVIDIA device plugin for Kubernetes
Apache License 2.0
2.45k stars 573 forks source link

nvidia-device-plugin.hasConfigMap returns a string #689

Open fraenkel opened 2 weeks ago

fraenkel commented 2 weeks ago

2. Issue or feature description

The helm chart helper nvidia-device-plugin.hasConfigMap attempts to return true/false but an include will always return a string.

Some places handled this properly by comparing to true while other places used the string as a guard.

3. Information to attach

https://github.com/NVIDIA/k8s-device-plugin/blob/main/deployments/helm/nvidia-device-plugin/templates/role.yml#L1 https://github.com/NVIDIA/k8s-device-plugin/blob/main/deployments/helm/nvidia-device-plugin/templates/service-account.yml#L1 https://github.com/NVIDIA/k8s-device-plugin/blob/main/deployments/helm/nvidia-device-plugin/templates/role-binding.yml#L1