Open wawa0210 opened 7 months ago
@klueska @elezar
friendly ping
Looking forward to review, especially detactSupportTimeSliceByArch
needs to add more architecture and needs a complete support matrix
Can you help me update this form?
arch | support timeslice |
---|---|
Fermi | unknow |
Kepler | unknow |
Maxwell | unknow |
Pascal | false |
Volta | unknow |
Turing | true |
Ampere | true |
Hopper | true |
Ada | true |
Another quesiton that I have is what we expect the behavior to be when timeslicing is configured on a GPU that doesn't support it? Do we expect an error to be raised, or do we want to continue assuming blocking operation if the GPU is shared?
I think we should error out and not start the plugin.
Another quesiton that I have is what we expect the behavior to be when timeslicing is configured on a GPU that doesn't support it? Do we expect an error to be raised, or do we want to continue assuming blocking operation if the GPU is shared?
I think we should error out and not start the plugin.
Do you mean that a gpu card that does not support settings time slice will not be able to use this function and will error out ?
@elezar @klueska friendly ping
@elezar @klueska friendly ping
@wawa0210 as already requested, it would be better if we return an error if timeslicing is configured on a GPU that doesn't support it. This will align with what is done for MIG.
I understand that crashing the plugin at this stage may not be desireable, but that is a separate issue that we would need to address.
@elezar @klueska friendly ping
@wawa0210 as already requested, it would be better if we return an error if timeslicing is configured on a GPU that doesn't support it. This will align with what is done for MIG.
I understand that crashing the plugin at this stage may not be desireable, but that is a separate issue that we would need to address.
Agree with you, updated,maybe we should discuss this scenario in a separate issue --> https://github.com/NVIDIA/k8s-dra-driver/issues/81
@elezar PTAL
/kind feature
fix https://github.com/NVIDIA/k8s-dra-driver/issues/41
Flexible judgment based on the GPU architecture series. If the model does not support time slices, ignore the settings to ensure normal operation of the function.
Test Results
Tesla P4 can run demo1 normally https://github.com/NVIDIA/k8s-dra-driver/blob/main/demo/specs/quickstart/gpu-test1.yaml