search

NVIDIA / k8s-dra-driver

Dynamic Resource Allocation (DRA) for NVIDIA GPUs in Kubernetes
Apache License 2.0
212 stars 38 forks source link

Unclear field definition gpuClaimName in MigDeviceClaimParameters #68

Open cyclinder opened 6 months ago

cyclinder commented 6 months ago

Hi, I noticed that GpuClaimParametersName is the name of the ResourceClaim and not the GpuClaimParameters,right?

https://github.com/NVIDIA/k8s-dra-driver/blob/b6c7aae2b87d857668f417689462da752090406f/api/nvidia.com/resource/gpu/v1alpha1/migclaim.go#L29

Refer to https://docs.google.com/document/d/1BNWqgx_SmZDi-va_V31v3DnuVwYnF2EmN7D-O_fB6Oo:

This object also includes a forward reference to the (yet-to-be-created) resource claim of the MIG enabled GPU on which this MIG device should be created (shared-gpu). Note this is the name of the resource claim itself, not the claim parameters object we called mig-enabled-gpu

If so, this may be ambiguous and we should update it to avoid ambiguity:

GpuClaimParametersName -> GpuResourceClaimName