NVIDIA / libnvidia-container

NVIDIA container runtime library
Apache License 2.0
843 stars 205 forks source link

Ubuntu libnvidia-container.list always points to 18.04 builds #175

Closed earlruby closed 2 years ago

earlruby commented 2 years ago

https://nvidia.github.io/libnvidia-container/ has instructions for installing repos for Ubuntu 20.04 and 22.04. The repo apt-source files are:

https://nvidia.github.io/libnvidia-container/ubuntu20.04/libnvidia-container.list https://nvidia.github.io/libnvidia-container/ubuntu22.04/libnvidia-container.list

Both of which contain pointers to an 18.04 repository:

deb https://nvidia.github.io/libnvidia-container/stable/ubuntu18.04/$(ARCH) /
#deb https://nvidia.github.io/libnvidia-container/experimental/ubuntu18.04/$(ARCH) /
elezar commented 2 years ago

The Ubuntu 18.04 packages are forward-compatible. We provide redirects from Ubuntu 20.04 and 22.04 for convenience. The presence of the ubuntu18.04 string in the .list file is expected.

Please see the explanation here and the notes on the presence of ubuntu18.04 in the repo list file here.

I am closing this issue. If you have trouble installing the packages or these do not work as expected please update this issue or open a new one.

earlruby commented 2 years ago

I understand that the packages are forward-compatible. I understand that https://nvidia.github.io/libnvidia-container/stable/ubuntu18.04/, https://nvidia.github.io/libnvidia-container/stable/ubuntu20.04/, and https://nvidia.github.io/libnvidia-container/stable/ubuntu22.04/ all point to the same files.

What I think you're missing is that if a user installs the repo on an Ubuntu 22.04 system today, the links in the repo point to a repository with a URL https://nvidia.github.io/libnvidia-container/stable/ubuntu18.04/, and this project is going to stop updating that URL well before 22.04 stops being supported.

Ubuntu 18.04 reaches end-of-maintenance in April 2023. Ubuntu 22.04 reaches end of standard support in April 2027. Sometime between those two dates you'll stop updating the files that are pointed to by https://nvidia.github.io/libnvidia-container/stable/ubuntu18.04/, and you'll break package updates on every 20.04 and 22.04 system using the 18.04 repo.

On Tue, Jun 14, 2022 at 12:29 AM Evan Lezar @.***> wrote:

The Ubuntu 18.04 packages are forward-compatible. We provide redirects from Ubuntu 20.04 and 22.04 for convenience. The presence of the ubuntu18.04 string in the .list file is expected.

Please see the explanation here https://docs.nvidia.com/datacenter/cloud-native/container-toolkit/install-guide.html#linux-distributions and the notes on the presence of ubuntu18.04 in the repo list file here https://docs.nvidia.com/datacenter/cloud-native/container-toolkit/install-guide.html#setting-up-nvidia-container-toolkit .

I am closing this issue. If you have trouble installing the packages or these do not work as expected please update this issue or open a new one.

— Reply to this email directly, view it on GitHub https://github.com/NVIDIA/libnvidia-container/issues/175#issuecomment-1154819298, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJWDGO7C5KVQWSB2WU4XVTVPAYGJANCNFSM5YVWIXSQ . You are receiving this because you authored the thread.Message ID: @.***>

-- Earl Ruby http://earlruby.org/ http://www.linkedin.com/in/earlruby https://twitter.com/earlruby

elezar commented 2 years ago

That's a valid point @earlruby. We will look at reorganising how we distribute our packages.

Dovermore commented 2 years ago

Just adding another comment. I am currently using linux mint 20.3 (Una). And the redirected Ubuntu 18.04 does not work for me. To be precise, when running sudo apt update, the release does not showup as one of the repos (forgive me if my terminology is wrong, I am unfamiliar with apt terms). It is only fixed after manually changing the .gpg file to use ubuntu20.04.

dlong500 commented 2 months ago

@elezar Why is this issue still closed given the point @earlruby made? It's now more than two years later and it seems that nothing has changed with the organization. If the packages are forward compatible wouldn't it be more prudent to advertise proper release tags via the URL and then use symlinks behind the scenes to point to the shared package files?

Also, Ubuntu 24.04 has been out for quite a while now but I don't even see a redirect for that version.

EDIT I do now see issue #218 which details a reorganization to generic deb packages versus the distribution names. Sorry for missing that. Linking the relevant issue here for anyone else who comes across this.