search

NVIDIA / mellotron

Mellotron: a multispeaker voice synthesis model based on Tacotron 2 GST that can make a voice emote and sing without emotive or singing training data
BSD 3-Clause "New" or "Revised" License
853 stars 187 forks source link

Small necessary corrections in text/__init__.py #82

Closed Jeevesh8 closed 3 years ago

Jeevesh8 commented 3 years ago

@rafaelvalle sir, please see. I have added a necessary else , to avoid the error that comes when trying to access.group() of the None returned by .match() call.

rafaelvalle commented 3 years ago

Can you share the sentence and context that produced an error with the current code?

Jeevesh8 commented 3 years ago

Sorry. This was wrong. You have a while loop over text.. I didn't see that. My sentence was producing error due to other reasons. Thank you.

But, I came across another thing, while trying this out.. shouldn't this line have dictionary instead of cmudict ? Or is this the intended behavior ?

rafaelvalle commented 3 years ago

Yes, that should be dictionary as there is no cmudict in that scope. Can you please put a PR?