Open cfd1 opened 1 year ago
The resolution also needs updating as the gifs are quite large now.
Example of the new visualisation. The model hasn't been trained enough to give good results, but it illustrates the visualisation.
And an example of the rollout loss plot
The resolution also needs updating as the gifs are quite large now.
This was fixed in the last commit
The examples don’t appear to have tests, do I need to add some? For documentation launch only has an ApI doc, is there any documentation for me to update for this change?
Hi @cfd1 , thanks for the PR! Is this ready for review?
@mnabian yes, it's ready for a review please
The examples don’t appear to have tests, do I need to add some? For documentation launch only has an ApI doc, is there any documentation for me to update for this change?
No you don't need to add tests for the examples. For documentation, take a look at the README file for the vortex shedding example and see if anything needs to be updated. Thanks
@cfd1 thanks again for the PR! It looks good to me, I just left a single comment for you about the resolution.
/blossom-ci
Modulus Pull Request
Description
Aims to improve the inference code with an error plot and colourbars. There is a start of the code to plot the loss over the rollout. Needs cleaning up and generalising.
Checklist
Dependencies
Depends on PR #111