search

NVIDIA / modulus-sym

Framework providing pythonic APIs, algorithms and utilities to be used with Modulus core to physics inform model training as well as higher level abstraction for domain experts
https://developer.nvidia.com/modulus
Apache License 2.0
138 stars 56 forks source link

🐛[BUG]: Incorrect non-dimensionalization in the Chip 2D example #109

Closed ram-cherukuri closed 4 months ago

ram-cherukuri commented 5 months ago

Version

1.4.0

On which installation method(s) does this occur?

No response

Describe the issue

In the Chip_2D example, in chip_2d_solid_fluid_heat_transfer_heat.py - the non dimensionalizing below is incorrect

nd_copper_source_grad = copper_heat_flux * length_scale / temp_scale

Looks like final units are W/m^2/m-K = kg m^2 / s^3 /m^2 /m-K = kg / s^3 /m-K

This needs to be fixed. Also the idea of non-dimensionalization should be clarified if we are not making some assumptions.

Minimum reproducible example

No response

Relevant log output

No response

Environment details

No response

Other/Misc.

No response

ktangsali commented 4 months ago

There seems to be a typo in the example code. The copper_heat_flux is actually in dT/dx format, hence the Flux is 51.94 K/m (20000 W/m^2). The subsequent non-dimensionalization is correct. I will open a quick PR to fix this.