search

NVIDIA / modulus-sym

Framework providing pythonic APIs, algorithms and utilities to be used with Modulus core to physics inform model training as well as higher level abstraction for domain experts
https://developer.nvidia.com/modulus
Apache License 2.0
163 stars 68 forks source link

🐛[BUG]: dimensions in Chip 2D example #120

Open shourya-p-otta opened 7 months ago

shourya-p-otta commented 7 months ago

Version

23.09,23.11, 24.01

On which installation method(s) does this occur?

No response

Describe the issue

nd_copper_source_grad = copper_heat_flux * length_scale / temp_scale is not non-dimensional. Looks like final units are W/m^2/m-K = kg m^2 / s^3 /m^2 /m-K = kg / s^3 /m-K. This needs to be fixed.

https://github.com/NVIDIA/modulus-sym/blob/dc5c0f759bb19e710fae0ba70cda63e129102774/examples/chip_2d/chip_2d_solid_fluid_heat_transfer_heat.py#L115

Minimum reproducible example

No response

Relevant log output

No response

Environment details

No response

Other/Misc.

No response

ktangsali commented 7 months ago

@shourya-p-otta please refer this issue here: https://github.com/NVIDIA/modulus-sym/issues/109. This was a typo that was addressed recently

shourya-p-otta commented 7 months ago

@ktangsali the results need to be updated as well in the documentation.