NVIDIA / modulus-sym

Framework providing pythonic APIs, algorithms and utilities to be used with Modulus core to physics inform model training as well as higher level abstraction for domain experts

https://developer.nvidia.com/modulus

Apache License 2.0

137 stars 56 forks source link

Add inference analysis for the turbulence super resolution example #154

Closed ktangsali closed 2 days ago

ktangsali commented 3 weeks ago

Modulus Pull Request

Description

Adds inference analysis for the turbulent super resolution example.

Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.
[x] The CHANGELOG.md is up to date with these changes.
[x] An issue is linked to this pull request.

Dependencies

ktangsali commented 3 weeks ago

/blossom-ci

ktangsali commented 3 weeks ago

/blossom-ci

ktangsali commented 3 days ago

This looks quite good to me. I have two main comments:

The first energy spectrum plot is super noisy. Is that not doing any averaging? Also, what is the difference compared to the next energy spectrum plot?

For the continuity residual, would be better to plot a histogram of the first invariant of the velocity gradient tensor, P, similar to how you compute Q and R.

Thanks Akshay, I have addressed your comments. Added plots for P invariant and also cleaned up the spectrum plots.

Please take a look!

ktangsali commented 3 days ago

/blossom-ci

ktangsali commented 3 days ago

/blossom-ci