search

NVIDIA / modulus-sym

Framework providing pythonic APIs, algorithms and utilities to be used with Modulus core to physics inform model training as well as higher level abstraction for domain experts
https://developer.nvidia.com/modulus
Apache License 2.0
147 stars 60 forks source link

fix: add missing terms in NS equation #25

Closed misawann closed 1 year ago

misawann commented 1 year ago

Closes #22 Add missing terms in the implemented Navier Stokes equation as discussed in the issue.

ktangsali commented 1 year ago

Thanks @misawann for fixing this. I can verify the fixes. For future reference can you also add reference links here: https://github.com/NVIDIA/modulus-sym/pull/25/files#diff-dc32422e77e593293a195d8a672cdcb93f343b4d97284b7dabe6b4f3c7e38743R27.

You can either use https://turbmodels.larc.nasa.gov/implementrans.html or the book by Wilcox (Wilcox, David C. Turbulence modeling for CFD. Vol. 2. La Canada, CA: DCW industries, 1998).

misawann commented 1 year ago

@ktangsali I don't have any appropriate reference as I derived the missing terms by myself, so I attatched your link as a reference. Thank you.