NVIDIA / modulus-sym

Framework providing pythonic APIs, algorithms and utilities to be used with Modulus core to physics inform model training as well as higher level abstraction for domain experts

https://developer.nvidia.com/modulus

Apache License 2.0

138 stars 56 forks source link

Integrating Sym with Core: Network Architecture Layers #62

Closed mnabian closed 9 months ago

mnabian commented 9 months ago

Modulus Pull Request

Description

Closes https://github.com/NVIDIA/modulus-sym/issues/64

Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.
[x] The CHANGELOG.md is up to date with these changes.
[x] An issue is linked to this pull request.

Dependencies

mnabian commented 9 months ago

/blossom-ci

loliverhennigh commented 9 months ago

We can pull over sym.models.activation to core as well but maybe we can make that a separate PR and leave it for the future unless you think its easy to do now.

mnabian commented 9 months ago

We can pull over sym.models.activation to core as well but maybe we can make that a separate PR and leave it for the future unless you think its easy to do now.

@loliverhennigh it requires some refactoring, as we already have some activations in core: https://github.com/NVIDIA/modulus/blob/main/modulus/models/layers/activations.py Let us track this in a separate PR.

mnabian commented 9 months ago

/blossom-ci

mnabian commented 9 months ago

/blossom-ci

mnabian commented 9 months ago

/blossom-ci

mnabian commented 9 months ago

/blossom-ci